http://codereview.chromium.org/3068001/diff/40001/41007 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3068001/diff/40001/41007#newcode756 src/arm/codegen-arm.cc:756: frame_->PopToR0(); Is there any need to force tos to R0? It is passed to the ToBooleanStub so it should be ok th have either r0 or r1 given that this is encoded in the stub minor key. http://codereview.chromium.org/3068001/diff/40001/41006 File src/codegen.h (right): http://codereview.chromium.org/3068001/diff/40001/41006#newcode727 src/codegen.h:727: explicit ToBooleanStub(Register tos = no_reg) : tos_(tos) { } I don't think the default value for the argument is required. http://codereview.chromium.org/3068001/diff/40001/41006#newcode733 src/codegen.h:733: int MinorKey() { return 0; } Encode tos_ in MinorKey. http://codereview.chromium.org/3068001/diff/40001/41002 File src/objects.cc (right): http://codereview.chromium.org/3068001/diff/40001/41002#newcode115 src/objects.cc:115: Object* Object::ToBooleanSlowPart() { Do we need this in objects.cc? How about just having this code in runtime.cc? http://codereview.chromium.org/3068001/diff/40001/41002#newcode1174 src/objects.cc:1174: #if defined(__arm__) Please avoid platform specific code in platform independent files. I suppose that the bit checking will work on all platforms anyway, so why not just use it instead of fpclassify? Btw is fpclassify missing on some platforms or is there another motivation for checking the bits? http://codereview.chromium.org/3068001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
