I fixed comments. During tweaking I had to rebase my branch so I uploaded
fixed
version separately:
http://codereview.chromium.org/3066044
http://codereview.chromium.org/3023033/diff/5001/6002
File src/arm/assembler-arm-inl.h (right):
http://codereview.chromium.org/3023033/diff/5001/6002#newcode173
src/arm/assembler-arm-inl.h:173: void RelocInfo::Visit(ObjectVisitor*
visitor) {
On 2010/08/03 20:09:09, Erik Corry wrote:
Can't you just replace this entire implementation with a call to the
templatized
version now?
No. It seems impossible to me.
http://codereview.chromium.org/3023033/diff/5001/6004
File src/bootstrapper.cc (right):
http://codereview.chromium.org/3023033/diff/5001/6004#newcode42
src/bootstrapper.cc:42: #include "objects-iteration.h"
On 2010/08/03 20:09:09, Erik Corry wrote:
Can't this be with the others in alphabetical order?
Done.
http://codereview.chromium.org/3023033/diff/5001/6006
File src/heap.cc (right):
http://codereview.chromium.org/3023033/diff/5001/6006#newcode48
src/heap.cc:48: #include "objects-iteration.h"
On 2010/08/03 20:09:09, Erik Corry wrote:
Alpha order?
Done.
http://codereview.chromium.org/3023033/diff/5001/6012
File src/objects-inl.h (right):
http://codereview.chromium.org/3023033/diff/5001/6012#newcode2094
src/objects-inl.h:2094: int HeapObject::SizeFromMap(Map* map) {
On 2010/08/03 20:09:09, Erik Corry wrote:
Not worth making this into a virtually dispatched getter?
I do not think it will worth it.
http://codereview.chromium.org/3023033/diff/5001/6016
File src/objects.h (right):
http://codereview.chromium.org/3023033/diff/5001/6016#newcode2519
src/objects.h:2519: class BodyDescriptor : public
FlexibleBodyDescriptor<kHeaderSize> {
On 2010/08/03 20:09:09, Erik Corry wrote:
Does a byte array need a flexible body descriptor?
It seems it does not. Removed.
http://codereview.chromium.org/3023033/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
