Reviewers: Mads Ager,
Message:
Mads,
may you review this patch by Vlad.
He failed to upload it from his box, so I had to upload it from mine.
Description:
Add v8::Value::IsRegExp method.
Patch by Vlad Burlik.
Please review this at http://codereview.chromium.org/3064051/show
Affected files:
M AUTHORS
M include/v8.h
M src/api.cc
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
4d87db3be0b3998268d86b5f18c83dde78e006bc..65b8965f1a53afcdc58344ad0907ac5cf9a819f2
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -29,4 +29,5 @@ Rodolph Perfetta <[email protected]>
Ryan Dahl <[email protected]>
Subrato K De <[email protected]>
Burcu Dogan <[email protected]>
+Vlad Burlik <[email protected]>
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
3ac10ab917d8801b5904343f897c91c0f6f37f14..b22e3d1f4bb50e37ecad2ebdbf8052629fc76bb0
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -919,6 +919,11 @@ class Value : public Data {
*/
V8EXPORT bool IsDate() const;
+ /**
+ * Returns true if this value is a RegExp.
+ */
+ V8EXPORT bool IsRegExp() const;
+
V8EXPORT Local<Boolean> ToBoolean() const;
V8EXPORT Local<Number> ToNumber() const;
V8EXPORT Local<String> ToString() const;
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
adeced54b5fe1a043ddfee55f92d4a1193ffc565..4bd5699c000cfacfe76276cfbada39426f52fde4
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -1792,6 +1792,13 @@ bool Value::IsDate() const {
}
+bool Value::IsRegExp() const {
+ if (IsDeadCheck("v8::Value::IsRegExp()")) return false;
+ i::Handle<i::Object> obj = Utils::OpenHandle(this);
+ return obj->IsJSRegExp();
+}
+
+
Local<String> Value::ToString() const {
if (IsDeadCheck("v8::Value::ToString()")) return Local<String>();
LOG_API("ToString");
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
