LGTM.
http://codereview.chromium.org/3120006/diff/16001/17007 File src/handles.cc (right): http://codereview.chromium.org/3120006/diff/16001/17007#newcode778 src/handles.cc:778: CompilationInfo info(function, 0, receiver); Indentation is off here. http://codereview.chromium.org/3120006/diff/16001/17008 File src/heap.cc (right): http://codereview.chromium.org/3120006/diff/16001/17008#newcode2466 src/heap.cc:2466: Extra newline between the functions. http://codereview.chromium.org/3120006/diff/16001/17008#newcode2468 src/heap.cc:2468: SharedFunctionInfo* function_info = function->shared(); I would call this shared_info instead of function_info. http://codereview.chromium.org/3120006/diff/16001/17008#newcode2470 src/heap.cc:2470: // Special handling if the function and sharedfunctioninfo objects sharedfunctioninfo => shared info http://codereview.chromium.org/3120006/diff/16001/17008#newcode2474 src/heap.cc:2474: // we flush the function if posible. posible => possible. http://codereview.chromium.org/3120006/diff/16001/17008#newcode2501 src/heap.cc:2501: // Check stack and archived threads for the code Terminate comment with . http://codereview.chromium.org/3120006/diff/16001/17008#newcode2520 src/heap.cc:2520: JSFunction* jsfunction = JSFunction::cast(obj); jsfunction => function http://codereview.chromium.org/3120006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
