LGTM
http://codereview.chromium.org/3066044/diff/1/2 File SConstruct (right): http://codereview.chromium.org/3066044/diff/1/2#newcode152 SConstruct:152: '-g'], Noooo! http://codereview.chromium.org/3066044/diff/1/8 File src/heap.cc (right): http://codereview.chromium.org/3066044/diff/1/8#newcode1097 src/heap.cc:1097: VisitSpecialized<ConsString::kSize>); This line should be indented 4 more spaces so it doesn't look like a 3rd argument. http://codereview.chromium.org/3066044/diff/1/8#newcode1101 src/heap.cc:1101: VisitSpecialized<SharedFunctionInfo::kSize>); And here. http://codereview.chromium.org/3066044/diff/1/13 File src/objects-debug.cc (right): http://codereview.chromium.org/3066044/diff/1/13#newcode33 src/objects-debug.cc:33: #include "objects-iteration.h" Do you need this? http://codereview.chromium.org/3066044/diff/1/15 File src/objects-iteration.cc (right): http://codereview.chromium.org/3066044/diff/1/15#newcode39 src/objects-iteration.cc:39: There's a missing blank line here. http://codereview.chromium.org/3066044/diff/1/16 File src/objects-iteration.h (right): http://codereview.chromium.org/3066044/diff/1/16#newcode57 src/objects-iteration.h:57: #define PRODUCE_SPECIALIZATIONS(base) \ I don't think this macro is worth it. Also please add a comment that these are specialized on word size. http://codereview.chromium.org/3066044/diff/1/16#newcode67 src/objects-iteration.h:67: base##10 \ Missing space http://codereview.chromium.org/3066044/diff/1/16#newcode94 src/objects-iteration.h:94: // For visitors that allow specilization by size calculate VisitorId based specilization -> specialization http://codereview.chromium.org/3066044/diff/1/16#newcode106 src/objects-iteration.h:106: static_cast<int>(kSpecializedVisitorMaxWords)) - 2); Do you need the cast? Moving the -2 to be after 'base' would make it easier to see that it was outside the Min() call. The '2' should be named. http://codereview.chromium.org/3066044/diff/1/16#newcode124 src/objects-iteration.h:124: callbacks_[id] = callback; Add an assert on the size of callbacks_? http://codereview.chromium.org/3066044/diff/1/18 File src/objects.h (right): http://codereview.chromium.org/3066044/diff/1/18#newcode1113 src/objects.h:1113: // in which all pointer fields are located in [start_offset, end_offset) in -> in the http://codereview.chromium.org/3066044/diff/1/18#newcode1132 src/objects.h:1132: // This class describes a body of an object of a varible size varible -> variable http://codereview.chromium.org/3066044/diff/1/18#newcode1133 src/objects.h:1133: // in which all pointer fields are located in [start_offset, object_size) in -> in the http://codereview.chromium.org/3066044/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
