http://codereview.chromium.org/3144002/diff/1/2 File src/builtins.cc (right):
http://codereview.chromium.org/3144002/diff/1/2#newcode357 src/builtins.cc:357: return array->EnsureWritableFastElements(); just as an idea for speed up: maybe we could add utility function to turn elements into writables with api like: JSArray::TurnToWritables(FixedArray* elements) which bypasses map check and elements lookup. But I don't know how much will it buy us. Overall, do you know how many COW arrays come into builtins in Dromaeo array benchmark? http://codereview.chromium.org/3144002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
