LGTM, but wait for LRN.

http://codereview.chromium.org/3170004/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/3170004/diff/1/2#newcode2484
src/arm/codegen-arm.cc:2484: __ mov(r3, Operand(r0));
make this a SetCC operation and omit the tst.

http://codereview.chromium.org/3170004/diff/1/3
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/3170004/diff/1/3#newcode960
src/arm/full-codegen-arm.cc:960: // anymore. If the property has been
removed while iterating, we
anymore -> any more

http://codereview.chromium.org/3170004/diff/1/3#newcode966
src/arm/full-codegen-arm.cc:966: __ tst(r3, r3);
And again.

http://codereview.chromium.org/3170004/diff/1/9
File test/mjsunit/for-in-delete.js (right):

http://codereview.chromium.org/3170004/diff/1/9#newcode28
test/mjsunit/for-in-delete.js:28: // Test that properties deleted during
a for-in iteration does not show up in
properties ... does -> properties ... do

http://codereview.chromium.org/3170004/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to