LGTM
http://codereview.chromium.org/3166008/diff/1/3 File tools/v8.xcodeproj/project.pbxproj (right): http://codereview.chromium.org/3166008/diff/1/3#newcode252 tools/v8.xcodeproj/project.pbxproj:252: C2D1E9731212F2BC00187A52 /* objects-visiting.cc in Sources */ = {isa = PBXBuildFile; fileRef = C2D1E9711212F27B00187A52 /* objects-visiting.cc */; }; I only think you need to add this once. http://codereview.chromium.org/3166008/diff/1/3#newcode733 tools/v8.xcodeproj/project.pbxproj:733: C2D1E9711212F27B00187A52 /* objects-visiting.cc */, Look out for exploding cigars! http://codereview.chromium.org/3166008/diff/1/3#newcode1277 tools/v8.xcodeproj/project.pbxproj:1277: C2D1E9731212F2BC00187A52 /* objects-visiting.cc in Sources */, And here! http://codereview.chromium.org/3166008/diff/1/3#newcode1401 tools/v8.xcodeproj/project.pbxproj:1401: C2D1E9741212F2CF00187A52 /* objects-visiting.cc in Sources */, And here! http://codereview.chromium.org/3166008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
