Thanks for the feedback! Here are the numbers for this version:
ia32: ++Crypto: 1880.750000 --closure-json-raw: 350.000000 ++EarleyBoyer: 5645.750000 ++ws-longfact: 103.500000 --closure-datetime-raw: 183.250000 ++Score (version 6 (candidate)): 537.500000 --closure-uri-raw: 170.750000 ++Solve: 77.075000 ++Splay: 326.250000 ++RegExp: 1462.500000 ++Richards: 2450.250000 --closure-queue2-raw: 3815.500000 --closure-eval2-raw: 117.000000 ++ws-IEEE754Conv: 85.050000 ++Genetic: 81.350000 ++RayTrace: 4099.000000 --closure-log-formatter-raw: 222.250000 ++ws-huffman: 92.375000 ++DeltaBlue: 2251.250000 x64: ++Crypto: 2041.500000 --closure-json-raw: 349.000000 ++EarleyBoyer: 5174.000000 ++ws-longfact: 104.925000 --closure-datetime-raw: 206.750000 ++Score (version 6 (candidate)): 530.000000 --closure-uri-raw: 177.750000 ++Solve: 88.025000 ++Splay: 306.250000 ++RegExp: 1413.500000 ++Richards: 2306.750000 --closure-queue2-raw: 3551.500000 --closure-eval2-raw: 135.750000 ++ws-IEEE754Conv: 92.200000 ++Genetic: 88.125000 ++RayTrace: 3751.500000 --closure-log-formatter-raw: 255.000000 ++ws-huffman: 88.425000 ++DeltaBlue: 1876.500000 http://codereview.chromium.org/3139005/diff/1/4 File src/objects-inl.h (right): http://codereview.chromium.org/3139005/diff/1/4#newcode1088 src/objects-inl.h:1088: Heap* Map::GetHeap() { On 2010/08/10 23:48:43, Dmitry Titov wrote:
If we move ASSERT for GC into Map::heap(), that one can be used
instead (I
assume you want to avoid extra dereference). Having non-virtual
methods with the
same signature on derived objects seems a bit dangerous...
I'm not sure what you mean by dangerous. http://codereview.chromium.org/3139005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
