Please take another look, hopefully this is less fragile.
http://codereview.chromium.org/3082012/diff/1/2 File src/messages.js (right): http://codereview.chromium.org/3082012/diff/1/2#newcode712 src/messages.js:712: this.receiver.__lookupSetter__(ownName) === this.fun || On 2010/08/10 08:29:38, Lasse Reichstein wrote:
Is __lookup[GS]etter__ safe to use, or can it be changed by the user? Would it be safer to use ES5 Object.getOwnPropertyDescriptor (+
perhaps
prototype traversal) instead?
You are right they can be changed, but so can Object.getOwnPropertyDescriptor. Changed to call the internal implementation: ObjectLookupGetter.call(this.receiver, ownName) ObjectLookupSetter.call(this.receiver, ownName) http://codereview.chromium.org/3082012/diff/1/3 File test/mjsunit/regress/regress-798.js (right): http://codereview.chromium.org/3082012/diff/1/3#newcode68 test/mjsunit/regress/regress-798.js:68: On 2010/08/10 08:29:38, Lasse Reichstein wrote:
Try adding tests where users have changed __defineGetter__.
Did you mean __lookupGetter__? As I am no longer using that in messages.js there is no need to test that? http://codereview.chromium.org/3082012/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
