LGTM with 2 nits.

http://codereview.chromium.org/3112010/diff/1/3
File src/d8-debug.h (right):

http://codereview.chromium.org/3112010/diff/1/3#newcode56
src/d8-debug.h:56: explicit RemoteDebugger(i::Isolate* isolate, int
port)
doesn't have to be 'explicit' any longer.

http://codereview.chromium.org/3112010/diff/1/3#newcode101
src/d8-debug.h:101: explicit ReceiverThread(i::Isolate* isolate,
RemoteDebugger* remote_debugger)
'explicit' too

http://codereview.chromium.org/3112010/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to