lgtm and thanks. yours, anton.
On Mon, Aug 16, 2010 at 9:11 PM, <[email protected]> wrote: > Reviewers: antonm, > > Description: > Array builtins: add inline modifier to help gcc. > > Please review this at http://codereview.chromium.org/3181013/show > > Affected files: > M src/builtins.cc > > > Index: src/builtins.cc > diff --git a/src/builtins.cc b/src/builtins.cc > index > 437bc1e6c1531de9e006c9d3fca766ef673d9e1b..eedee9f44784f1abaf3be9d130f0c5883ac9a276 > 100644 > --- a/src/builtins.cc > +++ b/src/builtins.cc > @@ -352,7 +352,7 @@ static bool ArrayPrototypeHasNoElements(Context* > global_context, > } > > > -static Object* EnsureJSArrayWithWritableFastElements(Object* receiver) { > +static inline Object* EnsureJSArrayWithWritableFastElements(Object* > receiver) { > if (!receiver->IsJSArray()) return NULL; > JSArray* array = JSArray::cast(receiver); > HeapObject* elms = HeapObject::cast(array->elements()); > @@ -364,7 +364,7 @@ static Object* > EnsureJSArrayWithWritableFastElements(Object* receiver) { > } > > > -static bool IsJSArrayFastElementMovingAllowed(JSArray* receiver) { > +static inline bool IsJSArrayFastElementMovingAllowed(JSArray* receiver) { > Context* global_context = Top::context()->global_context(); > JSObject* array_proto = > JSObject::cast(global_context->array_function()->prototype()); > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
