LGTM, but I would like to keep the normal casts instead of using reinterpret_cast. We should restrict the reinterpret_casts to GC to get the asserts for normal non-gc code.
http://codereview.chromium.org/3135026/diff/1/6 File src/frames.cc (right): http://codereview.chromium.org/3135026/diff/1/6#newcode410 src/frames.cc:410: return reinterpret_cast<Code*>(code_slot()); Doing these changes, we loose assertions in the code that is using this when not during GC. Should we add raw_unchecked accessors for the stuff needed during GC? http://codereview.chromium.org/3135026/diff/1/8 File src/heap-inl.h (right): http://codereview.chromium.org/3135026/diff/1/8#newcode422 src/heap-inl.h:422: return Handle<TYPE>(reinterpret_cast<TYPE*>(__object__)), \ Same here, loosing these assertions seems bad. http://codereview.chromium.org/3135026/diff/1/15 File src/objects-visiting.h (right): http://codereview.chromium.org/3135026/diff/1/15#newcode274 src/objects-visiting.h:274: &JSObjectVisitor::template VisitSpecialized<JSFunction::kSize>); Long line. http://codereview.chromium.org/3135026/diff/1/17 File src/objects.h (right): http://codereview.chromium.org/3135026/diff/1/17#newcode3483 src/objects.h:3483: inline int code_age(); Add comments please. http://codereview.chromium.org/3135026/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
