Comment #9 on issue 361 by [email protected]: ThreadSanitizer reports
dubious practices in V8
http://code.google.com/p/v8/issues/detail?id=361
One more (found on Chromium tests).
v8/src/v8threads.cc:
50 // Constructor for the Locker object. Once the Locker is constructed
the
51 // current thread will be guaranteed to have the big V8 lock.
52 Locker::Locker() : has_lock_(false), top_level_(true) {
53 // Record that the Locker has been used at least once.
54 active_ = true; // <<<<< Race is here!
v8/include/v8.h:
3164 class V8EXPORT Locker {
3165 public:
...
3188 /**
3189 * Returns whether v8::Locker is being used by this V8 instance.
3190 */
3191 static bool IsActive() { return active_; } // <<<<< Race is here!
...
3196
3197 static bool active_;
3198
...
3202 };
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
