Reviewers: Erik Corry, Description: Remove the virtual declaration from a couple of non-virtual JumpTarget methods to avoid compiler warnings with some gcc versions.
Please review this at http://codereview.chromium.org/3170036/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/jump-target-heavy.h Index: src/jump-target-heavy.h =================================================================== --- src/jump-target-heavy.h (revision 5312) +++ src/jump-target-heavy.h (working copy) @@ -117,17 +117,17 @@ // the target and the fall-through. virtual void Branch(Condition cc, Hint hint = no_hint); virtual void Branch(Condition cc, Result* arg, Hint hint = no_hint); - virtual void Branch(Condition cc, - Result* arg0, - Result* arg1, - Hint hint = no_hint); + void Branch(Condition cc, + Result* arg0, + Result* arg1, + Hint hint = no_hint); // Bind a jump target. If there is no current frame at the binding // site, there must be at least one frame reaching via a forward // jump. virtual void Bind(); virtual void Bind(Result* arg); - virtual void Bind(Result* arg0, Result* arg1); + void Bind(Result* arg0, Result* arg1); // Emit a call to a jump target. There must be a current frame at // the call. The frame at the target is the same as the current -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
