Reviewers: Kevin Millikin, Description: Improve header file inclusions. Drop some unneeded includes, and add some needed ones.
Please review this at http://codereview.chromium.org/3253001/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/contexts.h M src/flags.h M src/heap-inl.h M src/heap.h M src/objects-inl.h M src/v8.h Index: src/contexts.h =================================================================== --- src/contexts.h (revision 5361) +++ src/contexts.h (working copy) @@ -28,6 +28,9 @@ #ifndef V8_CONTEXTS_H_ #define V8_CONTEXTS_H_ +#include "heap.h" +#include "objects.h" + namespace v8 { namespace internal { Index: src/flags.h =================================================================== --- src/flags.h (revision 5361) +++ src/flags.h (working copy) @@ -27,8 +27,6 @@ #ifndef V8_FLAGS_H_ #define V8_FLAGS_H_ -#include "checks.h" - namespace v8 { namespace internal { Index: src/heap-inl.h =================================================================== --- src/heap-inl.h (revision 5361) +++ src/heap-inl.h (working copy) @@ -28,7 +28,8 @@ #ifndef V8_HEAP_INL_H_ #define V8_HEAP_INL_H_ -#include "log.h" +#include "heap.h" +#include "objects.h" #include "v8-counters.h" namespace v8 { Index: src/heap.h =================================================================== --- src/heap.h (revision 5361) +++ src/heap.h (working copy) @@ -30,6 +30,7 @@ #include <math.h> +#include "spaces.h" #include "splay-tree-inl.h" #include "v8-counters.h" Index: src/objects-inl.h =================================================================== --- src/objects-inl.h (revision 5361) +++ src/objects-inl.h (working copy) @@ -35,11 +35,13 @@ #ifndef V8_OBJECTS_INL_H_ #define V8_OBJECTS_INL_H_ -#include "memory.h" +#include "objects.h" #include "contexts.h" #include "conversions-inl.h" -#include "objects.h" +#include "heap.h" +#include "memory.h" #include "property.h" +#include "spaces.h" namespace v8 { namespace internal { Index: src/v8.h =================================================================== --- src/v8.h (revision 5361) +++ src/v8.h (working copy) @@ -60,9 +60,6 @@ #include "flags.h" // Objects & heap -#include "objects.h" -#include "spaces.h" -#include "heap.h" #include "objects-inl.h" #include "spaces-inl.h" #include "heap-inl.h" -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
