Reviewers: Mads Ager,
Message:
Mads,
tiny review for you if you please.
Description:
Add os_error stat to oom_dump utility.
Please review this at http://codereview.chromium.org/3150028/show
Affected files:
M tools/oom_dump/oom_dump.cc
Index: tools/oom_dump/oom_dump.cc
diff --git a/tools/oom_dump/oom_dump.cc b/tools/oom_dump/oom_dump.cc
index
ae14cde068f1b4529caf1757e7d1a9c8f4a217f4..1bf5ac19fc9d2561b80422a09cb28b6e8fbe8553
100644
--- a/tools/oom_dump/oom_dump.cc
+++ b/tools/oom_dump/oom_dump.cc
@@ -162,7 +162,7 @@ void DumpHeapStats(const char *minidump_file) {
ReadPointedValue(memory_region, heap_stats_addr, offset)
CHECK(READ_FIELD(0) == v8::internal::HeapStats::kStartMarker);
- CHECK(READ_FIELD(23) == v8::internal::HeapStats::kEndMarker);
+ CHECK(READ_FIELD(24) == v8::internal::HeapStats::kEndMarker);
const int new_space_size = READ_FIELD(1);
const int new_space_capacity = READ_FIELD(2);
@@ -184,6 +184,7 @@ void DumpHeapStats(const char *minidump_file) {
const int destroyed_global_handle_count = READ_FIELD(18);
const int memory_allocator_size = READ_FIELD(19);
const int memory_allocator_capacity = READ_FIELD(20);
+ const int os_error = READ_FIELD(23);
#undef READ_FIELD
int objects_per_type[v8::internal::LAST_TYPE + 1] = {0};
@@ -243,6 +244,7 @@ void DumpHeapStats(const char *minidump_file) {
PRINT_INT_STAT(destroyed_global_handle_count);
PRINT_MB_STAT(memory_allocator_size);
PRINT_MB_STAT(memory_allocator_capacity);
+ PRINT_INT_STAT(os_error);
#undef PRINT_STAT
printf("\n");
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
