LGTM if it compiles at least on GCC 4.3 and GCC 4.4
http://codereview.chromium.org/3274008/diff/1/12 File src/utils.h (right): http://codereview.chromium.org/3274008/diff/1/12#newcode955 src/utils.h:955: #ifdef __GNUC__ 1) GCC reference manual mentions this attribute starting from 3.4 so v8 will fail to compile by previous versions of GCC. 2) there are some differences in __attribute__ syntax [position of __attribute__ modifier for GCC <4 and GCC >=4]. See INLINE macro. 3) Can we come up with more informative name? NOIGNORE is difficult to understand. NOIGNORE what? 4) Maybe move this definitions to globals.h alongside with INLINE macroses? http://codereview.chromium.org/3274008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
