Thanks for the review! Submitted.
-- Vitaly http://codereview.chromium.org/3327001/diff/3001/4002 File src/ia32/code-stubs-ia32.h (right): http://codereview.chromium.org/3327001/diff/3001/4002#newcode241 src/ia32/code-stubs-ia32.h:241: // performed. This jump does not guarantee that the string is not in On 2010/09/01 11:19:31, Søren Gjesse wrote:
Maybe extend the comment to say that c1 and c2 are clobbered when a
jump to
not_found is performed.
Done. http://codereview.chromium.org/3327001/diff/3001/4002#newcode250 src/ia32/code-stubs-ia32.h:250: Label* not_probed, On 2010/09/01 11:19:31, Søren Gjesse wrote:
How about renaming not_probed to not_found_c1_c2_preserved? Maybe not?
I think having this described in the comment is enough. http://codereview.chromium.org/3327001/diff/3001/4003 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/3327001/diff/3001/4003#newcode787 src/ia32/macro-assembler-ia32.cc:787: Register scratch, On 2010/09/01 11:19:31, Søren Gjesse wrote:
Maybe add another scratch register and pass that as no_reg, leaving
the option
of avoiding the object reference in the reloc info to the caller.
Done. http://codereview.chromium.org/3327001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
