LGTM, with comments.
http://codereview.chromium.org/3312007/diff/1/2 File src/char-predicates-inl.h (right): http://codereview.chromium.org/3312007/diff/1/2#newcode37 src/char-predicates-inl.h:37: // If |c| is in 'A'-'Z' or 'a'-'z', return its lower-case. We don't traditionally use "|" around variables. Just write: "if c is in ..." http://codereview.chromium.org/3312007/diff/1/2#newcode40 src/char-predicates-inl.h:40: inline int ToLower(uc32 c) { Rename to AsciiAlphaToLower to make it clear that it doesn't work for non-alphabetic characters at all. A "ToLower" function would traditionally retain non-letter characters. http://codereview.chromium.org/3312007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
