Hi, I have now signed the CLA for individuals.
I got some good comments from Rodolph that I am now working with. I will upload a new snapshot when I am done with these. Best Regards, Andreas Anyuru On Sep 3, 3:03 pm, Erik Corry <[email protected]> wrote: > Hi Andreas. > > Thanks for the patch. > > Did you already sign the CLA as described > athttp://www.chromium.org/developers/contributing-code? > > 3. sep. 2010 14.17 skrev <[email protected]>: > > > > > Reviewers: Erik Corry, rodolph, > > > Message: > > Erik, Rodolph, > > > I have spent quite some time reading the v8 source code to understand the > > existing architecture. > > > This is an attempt to contribute a very small change to the ARM backend. > > > Is it possible for you to reivew it? > > >http://codereview.chromium.org/3341012/show > > > Regards, > > Andreas Anyuru > > > Description: > > Replace 2 ARM ldr instructions with one ldrd in the code generated for a > > SubStringStub in the ARM backend. > > > Please review this athttp://codereview.chromium.org/3341012/show > > > SVN Base:http://v8.googlecode.com/svn/branches/bleeding_edge/ > > > Affected files: > > M AUTHORS > > M src/arm/code-stubs-arm.cc > > > Index: AUTHORS > > =================================================================== > > --- AUTHORS (revision 5402) > > +++ AUTHORS (working copy) > > @@ -9,6 +9,7 @@ > > > Alexander Botero-Lowry <[email protected]> > > Alexandre Vassalotti <[email protected]> > > +Andreas Anyuru <[email protected]> > > Craig Schlenter <[email protected]> > > Daniel Andersson <[email protected]> > > Daniel James <[email protected]> > > Index: src/arm/code-stubs-arm.cc > > =================================================================== > > --- src/arm/code-stubs-arm.cc (revision 5402) > > +++ src/arm/code-stubs-arm.cc (working copy) > > @@ -4139,13 +4139,11 @@ > > // If any of these assumptions fail, we call the runtime system. > > > static const int kToOffset = 0 * kPointerSize; > > - static const int kFromOffset = 1 * kPointerSize; > > static const int kStringOffset = 2 * kPointerSize; > > > // Check bounds and smi-ness. > > - __ ldr(r7, MemOperand(sp, kToOffset)); > > - __ ldr(r6, MemOperand(sp, kFromOffset)); > > + __ ldrd(r6, r7, MemOperand(sp, kToOffset)); > > STATIC_ASSERT(kSmiTag == 0); > > STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 1); > > // I.e., arithmetic shift right by one un-smi-tags. > > -- > Erik Corry, Software Engineer > Google Denmark ApS - Frederiksborggade 20B, 1 sal, > 1360 København K - Denmark - CVR nr. 28 86 69 84 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
