Is the test coverage good enough. Do we have preparsing tests that actually exercise this code?
If we do, LGTM. http://codereview.chromium.org/3308010/diff/1/3 File src/parser.cc (right): http://codereview.chromium.org/3308010/diff/1/3#newcode899 src/parser.cc:899: Vector<const char> string) { Identation. http://codereview.chromium.org/3308010/diff/1/4 File src/parser.h (right): http://codereview.chromium.org/3308010/diff/1/4#newcode141 src/parser.h:141: // The following functions should only be cast after SanityCheck has returned cast -> called? http://codereview.chromium.org/3308010/diff/1/4#newcode152 src/parser.h:152: - (function_index_ - kHeaderSize)); This looks like funky indentation to me. I would add a pair of parenthesis and do: ASSERT(function_entries <= (static_cast<int>(store_[kFunctionsSizeOffset]) - (function_index_ - kHeaderSize))); http://codereview.chromium.org/3308010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
