LGTM. Two lines have become too long, and must be fixed.
http://codereview.chromium.org/3351010/diff/1/2 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/3351010/diff/1/2#newcode1063 src/arm/builtins-arm.cc:1063: __ mov(r2, Operand(0, RelocInfo::NONE)); // expected arguments is 0 for CALL_NON_FUNCTION Line too long. Make separate line or two lines, make "expected number of arguments is ..." http://codereview.chromium.org/3351010/diff/1/4 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/3351010/diff/1/4#newcode4615 src/arm/codegen-arm.cc:4615: __ rsb(scratch1, scratch1, Operand(0, RelocInfo::NONE), LeaveCC, mi); // Negate if negative. Is line <= 80 characters? http://codereview.chromium.org/3351010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
