http://codereview.chromium.org/3320005/diff/1/2 File src/ic.cc (right):
http://codereview.chromium.org/3320005/diff/1/2#newcode80 src/ic.cc:80: IC::IC(FrameDepth depth, Isolate* isolate) : isolate_(isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Assert the passed isolate is really the current one.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode598 src/ic.cc:598: in_loop, On 2010/09/03 12:08:27, Vitaly wrote:
nit: Fix formatting.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode602 src/ic.cc:602: in_loop, On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode645 src/ic.cc:645: in_loop, On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode659 src/ic.cc:659: in_loop, On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode920 src/ic.cc:920: *receiver); On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode1398 src/ic.cc:1398: *receiver, On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode1412 src/ic.cc:1412: *global, On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode1425 src/ic.cc:1425: *receiver, On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/2#newcode1453 src/ic.cc:1453: receiver->map(), On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/3 File src/ic.h (right): http://codereview.chromium.org/3320005/diff/1/3#newcode152 src/ic.h:152: Handle<Object> object, On 2010/09/03 12:08:27, Vitaly wrote:
nit: Fix indent.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode194 src/ic.h:194: explicit CallICBase(Code::Kind kind, Isolate* isolate) On 2010/09/03 12:08:27, Vitaly wrote:
"explicit" can be removed.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode224 src/ic.h:224: CallIC(Isolate* isolate) : CallICBase(Code::CALL_IC, isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Now needs "explicit".
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode240 src/ic.h:240: KeyedCallIC(Isolate* isolate) : CallICBase(Code::KEYED_CALL_IC, isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode258 src/ic.h:258: LoadIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode318 src/ic.h:318: KeyedLoadIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode399 src/ic.h:399: StoreIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode452 src/ic.h:452: KeyedStoreIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) { } On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/3#newcode526 src/ic.h:526: BinaryOpIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) { } On 2010/09/03 12:08:27, Vitaly wrote:
Ditto.
Done. http://codereview.chromium.org/3320005/diff/1/5 File src/stub-cache.cc (right): http://codereview.chromium.org/3320005/diff/1/5#newcode42 src/stub-cache.cc:42: StubCache::StubCache(Isolate* isolate) : isolate_(isolate) { On 2010/09/03 12:08:27, Vitaly wrote:
Add similar assert.
Done. http://codereview.chromium.org/3320005/diff/1/6 File src/stub-cache.h (right): http://codereview.chromium.org/3320005/diff/1/6#newcode270 src/stub-cache.h:270: StubCache(Isolate*); On 2010/09/03 12:08:27, Vitaly wrote:
"explicit"
Done. http://codereview.chromium.org/3320005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
