LGTM

http://codereview.chromium.org/3300020/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/3300020/diff/1/2#newcode2833
src/runtime.cc:2833: int plen = pattern.length();
Rename to "pattern_length". We try not to use too many abbreviations.

http://codereview.chromium.org/3300020/diff/1/2#newcode2883
src/runtime.cc:2883: int plen = pattern.length();
Ditto.

http://codereview.chromium.org/3300020/diff/1/2#newcode3050
src/runtime.cc:3050: int plen = pat.length();
And rename again (ahem, "pat" and "sub" should not be seen as an example
to copy :)

http://codereview.chromium.org/3300020/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to