LGTM

The ifndef/endif are correct for V8. I'm guessing your gcl lint uses chromium
rules (or something else).
You can lint v8 code by running tools/presubmit.py


http://codereview.chromium.org/3318017/diff/15001/16002
File test/mjsunit/regress/regress-857.js (right):

http://codereview.chromium.org/3318017/diff/15001/16002#newcode36
test/mjsunit/regress/regress-857.js:36: assertEquals(1283261736000,
Date.parse("2010-08-31T22:35:36.0+09:00"));
Looks good.
How about putting the spec-required formats (ES5 15.9.1.15) first, and
then the non-standardized ones after it?

http://codereview.chromium.org/3318017/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to