Drive by.
http://codereview.chromium.org/3291021/diff/1/3 File src/string-search.h (right): http://codereview.chromium.org/3291021/diff/1/3#newcode85 src/string-search.h:85: static int bad_char_occurrence[kBMAlphabetSize]; This does not belong in a header file. http://codereview.chromium.org/3291021/diff/1/3#newcode101 src/string-search.h:101: static void BoyerMoorePopulateBadCharTable(Vector<const pchar> pattern) { This must be declared inline if it's in a header file. I don't think you want to inline it anyway. http://codereview.chromium.org/3291021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
