http://codereview.chromium.org/3295022/diff/7001/8001 File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/3295022/diff/7001/8001#newcode888 src/arm/full-codegen-arm.cc:888: Register context = cp; This code might be clearer with some renaming: Register current = cp; Register next = r1; Register temp = r2; ... http://codereview.chromium.org/3295022/diff/7001/8001#newcode906 src/arm/full-codegen-arm.cc:906: context = tmp; // Walk the rest of the chain using a single register (without clobbering cp). current = next; http://codereview.chromium.org/3295022/diff/7001/8001#newcode916 src/arm/full-codegen-arm.cc:916: __ Move(tmp, context); Don't you know statically whether you've walked up the context chain? Could you do if (!tmp.is(context)) { __ Move(tmp, context); } http://codereview.chromium.org/3295022/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
