LGTM

http://codereview.chromium.org/3358025/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/3358025/diff/1/2#newcode7985
src/runtime.cc:7985: // How many elements does this array have?
Fix comment since we no longer assume this is an array

http://codereview.chromium.org/3358025/diff/1/3
File test/mjsunit/array-indexing.js (right):

http://codereview.chromium.org/3358025/diff/1/3#newcode103
test/mjsunit/array-indexing.js:103: assertEquals(100000,
Array.prototype.indexOf.call(sparse_object, 37));
Maybe add tests where we try to find the index of a non existing
property in the object?

http://codereview.chromium.org/3358025/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to