LGTM!
http://codereview.chromium.org/3301008/diff/5002/12003 File src/heap-profiler.h (right): http://codereview.chromium.org/3301008/diff/5002/12003#newcode45 src/heap-profiler.h:45: if (profiler && profiler->is_profiling()) { \ nit: Use explicit != NULL comparison. http://codereview.chromium.org/3301008/diff/5002/12004 File src/heap.cc (right): http://codereview.chromium.org/3301008/diff/5002/12004#newcode1181 src/heap.cc:1181: if (map->heap()->ShouldBePromoted(object->address(), object_size)) { We clearly need "heap" as a local variable here. http://codereview.chromium.org/3301008/diff/5002/12004#newcode1209 src/heap.cc:1209: *slot = MigrateObject(map->heap(), object, HeapObject::cast(result), object_size); nit: Long line. http://codereview.chromium.org/3301008/diff/5002/12004#newcode3674 src/heap.cc:3674: if (Heap::IteratePointersInDirtyRegion(HEAP, Heap lookup can be moved out of the while loop. http://codereview.chromium.org/3301008/diff/5002/12006 File src/mark-compact.cc (right): http://codereview.chromium.org/3301008/diff/5002/12006#newcode2489 src/mark-compact.cc:2489: int MarkCompactCollector::RelocateOldNonCodeObject(HeapObject* obj, It'd be really nice to make MarkCompactCollector::Relocate* non-static (then we could use the heap_ field). These methods are called by non-static IterateLiveObjectsInRange. Should be easy to pass "this" pointer there. Feel free to do this in a follow up change. http://codereview.chromium.org/3301008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
