Isolate tests are crashing after this change on x64:
Starting program: /sources/v8-isolates-git/obj/test/debug/cctest
test-api/RunDefaultAndAnotherIsolate
--testing_serialization_file=obj/test/debug/serdes_RunDefaultAndAnotherIsolate
--enable-slow-asserts --debug-code --verify-heap
warning: no loadable sections found in added symbol-file
/usr/lib/debug/lib/ld-2.7.so
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
0x00000000004c8006 in v8::internal::Space::identity
(this=0x7fffaef81010) at src/spaces.h:367
367 AllocationSpace identity() { return id_; }
(gdb) bt
#0 0x00000000004c8006 in v8::internal::Space::identity
(this=0x7fffaef81010) at src/spaces.h:367
#1 0x000000000068b01a in v8::internal::MemoryAllocator::DeleteChunk
(this=0x1102da0, chunk_id=3) at src/spaces.cc:660
#2 0x000000000068b407 in v8::internal::MemoryAllocator::TearDown
(this=0x1102da0) at src/spaces.cc:336
#3 0x000000000056f100 in v8::internal::Heap::TearDown
(this=0x113b228) at src/heap.cc:4409
#4 0x000000000058f591 in v8::internal::Isolate::Deinit
(this=0x113b190) at src/isolate.cc:417
#5 0x000000000058f5c3 in v8::internal::Isolate::TearDown
(this=0x113b190) at src/isolate.cc:392
#6 0x00000000004dfd1c in v8::Isolate::Dispose (this=0x113b190) at
src/api.cc:4027
#7 0x0000000000441147 in TestRunDefaultAndAnotherIsolate () at
test/cctest/test-api.cc:11410
#8 0x0000000000400a77 in CcTest::Run (this=0x10e7260) at
test/cctest/cctest.h:59
#9 0x0000000000400725 in main (argc=2, argv=0x7fffffffe468) at
test/cctest/cctest.cc:101
(gdb)
Looks like the same problem we encountered in the previous merge where
DeleteChunk tried to call PageSpace::excutable() on a space which had
already been deleted. Simplest fix here would be to store
Space::identity value in the ChunkInfo like we did with reputability
flag.
-yury
On Fri, Sep 10, 2010 at 4:18 PM, <[email protected]> wrote:
> LGTM!
>
> http://codereview.chromium.org/3310024/show
>
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
