Hi Kasper, Thanks for the explanation!
I don't fully understand the need to switch to d8 in order to support multiple flags because this functionality is a part of the runner script, but I assume you also have other tweaks in mind. My other concern with this change is that d8 has a more complex setup (it includes the debugger support) which can change the behavior in subtle ways and make some bugs harder or easier to reproduce. So my view on this is that a slight extension of the shell sample (beyond the simple flag switching that is already available) might be a better option if the other tweaks are simple. -- Vitaly On Tue, Sep 14, 2010 at 12:35 PM, Kasper Lund <[email protected]> wrote: > Hi Vitaly, > > The reason why we're experimenting with using d8 (instead of the shell > sample) to run the tests is that we're planning on adding various bits > of stress test support to the test runner (running a single test > multiple times with various flags), so that it will be easier to catch > problematic GC issues earlier. It seems a bit nasty to complicate the > shell sample with this support which is why we'd prefer to use d8. If > you have any concerns about using d8 for running the tests, we'd love > to hear them and try to address them. > > Cheers, > Kasper > > On Tue, Sep 14, 2010 at 10:03 AM, Vitaly Repeshko <[email protected]> > wrote: >> Guys, could you please explain the reasoning behind this? >> >> Thanks, >> Vitaly >> >> On Tue, Sep 14, 2010 at 11:59 AM, <[email protected]> wrote: >>> Shouldn't you be updating: >>> >>> test/es5conform/testcfg.py >>> test/mozilla/testcfg.py >>> test/sputnik/testcfg.py >>> >>> too? >>> >>> http://codereview.chromium.org/3410003/show >>> >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
