The IA-32 code looks good to me. Looking forward to seeing the x64 and ARM variants.
http://codereview.chromium.org/3439001/diff/1/3 File src/flag-definitions.h (right): http://codereview.chromium.org/3439001/diff/1/3#newcode177 src/flag-definitions.h:177: // full-codegen.cc / full-codegen-ia32.cc This will probably make sense for the other platforms soon. Maybe remove the -ia32.cc part of the comment? http://codereview.chromium.org/3439001/diff/1/6 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/3439001/diff/1/6#newcode2919 src/ia32/codegen-ia32.cc:2919: CompareFlags flags = ComputeCompareFlags(nan_info, inline_number_compare); Line too long. http://codereview.chromium.org/3439001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
