Revision: 5454
Author: [email protected]
Date: Tue Sep 14 09:38:02 2010
Log: Add a few missing nops to signal no inlined code was generated.

Review URL: http://codereview.chromium.org/3399005
http://code.google.com/p/v8/source/detail?r=5454

Modified:
 /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
 /branches/bleeding_edge/src/x64/full-codegen-x64.cc

=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Sun Sep 12 23:13:20 2010 +++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Tue Sep 14 09:38:02 2010
@@ -988,6 +988,7 @@
       ? RelocInfo::CODE_TARGET
       : RelocInfo::CODE_TARGET_CONTEXT;
   __ call(ic, mode);
+  __ nop();  // Signal no inlined code.
 }


@@ -3138,7 +3139,7 @@
     InLoopFlag in_loop = (loop_depth() > 0) ? IN_LOOP : NOT_IN_LOOP;
Handle<Code> ic = CodeGenerator::ComputeCallInitialize(arg_count, in_loop);
     __ call(ic, RelocInfo::CODE_TARGET);
-      // Restore context register.
+    // Restore context register.
     __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
   } else {
     // Call the C runtime function.
@@ -3483,6 +3484,7 @@
     // Use a regular load, not a contextual load, to avoid a reference
     // error.
     __ call(ic, RelocInfo::CODE_TARGET);
+    __ nop();  // Signal no inlined code.
     if (where == kStack) __ push(eax);
   } else if (proxy != NULL &&
              proxy->var()->slot() != NULL &&
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Sun Sep 12 23:13:20 2010 +++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Tue Sep 14 09:38:02 2010
@@ -938,6 +938,7 @@
       ? RelocInfo::CODE_TARGET
       : RelocInfo::CODE_TARGET_CONTEXT;
   __ call(ic, mode);
+  __ nop();  // Signal no inlined code.
 }


@@ -3174,6 +3175,7 @@
     // Use a regular load, not a contextual load, to avoid a reference
     // error.
     __ Call(ic, RelocInfo::CODE_TARGET);
+    __ nop();  // Signal no inlined code.
     if (where == kStack) __ push(rax);
   } else if (proxy != NULL &&
              proxy->var()->slot() != NULL &&

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to