LGTM
http://codereview.chromium.org/3384003/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3384003/diff/1/2#newcode1663 src/parser.cc:1663: symbol_id = Will fit on one line now. http://codereview.chromium.org/3384003/diff/1/2#newcode5514 src/parser.cc:5514: symbol_data_ = One line? The same for the next two assignments. http://codereview.chromium.org/3384003/diff/1/3 File src/parser.h (right): http://codereview.chromium.org/3384003/diff/1/3#newcode140 src/parser.h:140: // of unsigned ints (for function entries)/bytes (for symbol ids). I find this hard to read. Remove parenthesis? "number of unsigned ints for function entries and the given number of bytes for symbol ids." http://codereview.chromium.org/3384003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
