Drive by comment
http://codereview.chromium.org/3388004/diff/1/2 File src/assembler.h (right): http://codereview.chromium.org/3388004/diff/1/2#newcode100 src/assembler.h:100: class NearLabel BASE_EMBEDDED { How about adding a type to the Label class class Label ... enum LabelType { kTypeFar = ; kTypeNear = ; ... } Label(LabelType type = kTypeFar) ... LabelType type_; } the NearLabel class could then inherit from Label and construct a Label with type kTypeNear. Then the following two lines would achieve the same: Label label(Label::kTypeNear) NearLabel label http://codereview.chromium.org/3388004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
