LGTM, good catch Whether you want to move the checking to SharedFunctionInfo::SetThisPropertyAssignmentsInfo is up to you.
http://codereview.chromium.org/3434004/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/3434004/diff/1/2#newcode2717 src/heap.cc:2717: // guarantee the uniqueness of property names (it would have required We could do the sorting and checking for duplicates in SharedFunctionInfo::SetThisPropertyAssignmentsInfo instead. If there are duplicates then disable there. There we could also weed out all but the last assignment to a property and support the case of multiple assignments to a property, but it is probably (hopefuly) a rare case. If the sorting is done in SharedFunctionInfo::SetThisPropertyAssignmentsInfo we should not need to sort here. http://codereview.chromium.org/3434004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
