On 2010/09/20 06:50:08, Søren Gjesse wrote:
LGTM
Thanks!
http://codereview.chromium.org/3402014/diff/1/5
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/3402014/diff/1/5#newcode9431
src/ia32/codegen-ia32.cc:9431: masm()->mov(result.reg(),
Factory::null_value());
How about having a --debug-code guarded assert here that result.reg() is
never
null when this code is actually run.
Good idea. I added a check that this is actually a global cell.
-- Vitaly
http://codereview.chromium.org/3402014/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
