Yes that looks wrong! 17. sep. 2010 16.03 skrev BorisB <[email protected]>: > Hi > > The following code fragment in platform-linux.cc looks suspicious to > me: > > uint64_t OS::CpuFeaturesImpliedByPlatform() { > #if (defined(__VFP_FP__) && !defined(__SOFTFP__)) > // Here gcc is telling us that we are on an ARM and gcc is assuming > that we > // have VFP3 instructions. If gcc can assume it then so can we. > return 1u << VFP3; > #elif CAN_USE_ARMV7_INSTRUCTIONS <--- here > return 1u << ARMv7; > #else > return 0; // Linux runs on anything. > #endif > } > > I don't think those two are mutually exclusive. > > -- > Boris > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev >
-- Erik Corry, Software Engineer Google Denmark ApS - Frederiksborggade 20B, 1 sal, 1360 København K - Denmark - CVR nr. 28 86 69 84 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
