Added missing mark-compact.cc.
http://codereview.chromium.org/3329019/diff/15001/16001 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/3329019/diff/15001/16001#newcode693 src/arm/builtins-arm.cc:693: } // Otherwise r7 already holds undefined. On 2010/09/21 11:48:55, antonm wrote:
might be worth checking if FLAG_debug_code is enabled.
Done. http://codereview.chromium.org/3329019/diff/15001/16006 File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/3329019/diff/15001/16006#newcode598 src/ia32/assembler-ia32.h:598: void dec_b(const Operand& dst); Yes, I want to do that in a separate patch On 2010/09/21 11:48:55, antonm wrote:
apparently still no changes to disassembler
http://codereview.chromium.org/3329019/diff/15001/16007 File src/ia32/builtins-ia32.cc (right): http://codereview.chromium.org/3329019/diff/15001/16007#newcode191 src/ia32/builtins-ia32.cc:191: // To allow for truncation. On 2010/09/21 11:48:55, antonm wrote:
nit: do you want to unify with other platforms? e.g. there is no such
comment
in ARM port.
Done. http://codereview.chromium.org/3329019/diff/15001/16007#newcode193 src/ia32/builtins-ia32.cc:193: __ mov(edx, Factory::one_pointer_filler_map()); Added an assert at the top of the function on all 3 platforms. On 2010/09/21 11:48:55, antonm wrote:
we should never come here for API functions, correct? could we add
Assert here? http://codereview.chromium.org/3329019/diff/15001/16008 File src/objects-inl.h (right): http://codereview.chromium.org/3329019/diff/15001/16008#newcode2575 src/objects-inl.h:2575: kInobjectSlackTrackingMapOffset) Renamed to kInitialMapOffset On 2010/09/21 11:48:55, antonm wrote:
it is somewhat weird to see initial_map accessor with kInobjectSlackTrackingMapOffset. Could the names be adjusted?
http://codereview.chromium.org/3329019/diff/15001/16009 File src/objects.cc (right): http://codereview.chromium.org/3329019/diff/15001/16009#newcode5446 src/objects.cc:5446: void SharedFunctionInfo::ReleaseInitialMap() { Oops. Added. On 2010/09/21 11:48:55, antonm wrote:
apparently this CL is missing GC-part of the changes
http://codereview.chromium.org/3329019/diff/15001/16009#newcode5503 src/objects.cc:5503: void SharedFunctionInfo::CompleteInobjectSlackTracking() { It does not mean that. StartInobjectSlackTracking uses a flag (kHasConstructedObjects) to make sure the tracking is not started more than once (unless we want it to in the case when the tracking is cancelled by the GC). On 2010/09/21 11:48:55, antonm wrote:
does that mean that after CompleteInobjectSlackTracking is over,
another context
might initiate the process once again?
If yes, do we want it?
http://codereview.chromium.org/3329019/diff/15001/16010 File src/objects.h (right): http://codereview.chromium.org/3329019/diff/15001/16010#newcode3243 src/objects.h:3243: typedef int (*TraverseCallback)(Map* map, void* data); On 2010/09/21 11:48:55, antonm wrote:
apparently you don't need return type int for the callback--it's never
checked Done. http://codereview.chromium.org/3329019/diff/15001/16010#newcode3459 src/objects.h:3459: // after the constructor). There is no guarantee ther the extra space On 2010/09/21 11:48:55, antonm wrote:
ther -> that?
Done. http://codereview.chromium.org/3329019/diff/15001/16010#newcode3538 src/objects.h:3538: // May to go back from true to false if no constructed objects survived GC. Fixed a typo. Renamed to LiveObjectsMayExist (because 'true' result is conservative, not exact) On 2010/09/21 11:48:55, antonm wrote:
May to go -> may go
Maybe rename to HasLiveObjects()?
http://codereview.chromium.org/3329019/diff/15001/16013 File src/x64/builtins-x64.cc (right): http://codereview.chromium.org/3329019/diff/15001/16013#newcode1005 src/x64/builtins-x64.cc:1005: // To allow for truncation On 2010/09/21 11:48:55, antonm wrote:
nit: missing dot.
Done. http://codereview.chromium.org/3329019/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
