LGTM with comments.
http://codereview.chromium.org/3397021/diff/1/5 File src/mark-compact.cc (right): http://codereview.chromium.org/3397021/diff/1/5#newcode677 src/mark-compact.cc:677: RootMarkingVisitor(Heap* heap) Should be "explicit". http://codereview.chromium.org/3397021/diff/1/5#newcode1473 src/mark-compact.cc:1473: PointersToNewGenUpdatingVisitor(Heap* heap) : heap_(heap) { } ditto. http://codereview.chromium.org/3397021/diff/1/6 File src/objects-visiting.h (right): http://codereview.chromium.org/3397021/diff/1/6#newcode394 src/objects-visiting.h:394: HEAP, Code is a HeapObject, you can call GetHeap() instead of HEAP here. http://codereview.chromium.org/3397021/diff/1/7 File src/x64/assembler-x64-inl.h (right): http://codereview.chromium.org/3397021/diff/1/7#newcode358 src/x64/assembler-x64-inl.h:358: StaticVisitor::VisitPointer(HEAP, target_object_address()); We could try to get the Heap pointer from the target_object when it's a HeapObject but probably the performance gain won't worth the effort. http://codereview.chromium.org/3397021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
