Reviewers: fschneider,
Message:
I did not try to clean up the whole VariableProxy::AsVariable mess because
it
touches too many call sites.
Description:
Clean up some messiness in Scopes.
For some reason, the scope's arguments and arguments shadow were
variable proxies, which resulted in all references to the arguments
shadow being shared in the AST. This makes it hard to put per-node
state on the AST nodes.
I took the opportunity to remove Variable::AsVariable which has
confused people in the past, and to rename Variable::slot to the more
accurate Variable::AsSlot.
Please review this at http://codereview.chromium.org/3432022/show
Affected files:
M src/arm/codegen-arm.cc
M src/arm/full-codegen-arm.cc
M src/ast.h
M src/ast.cc
M src/codegen.cc
M src/data-flow.cc
M src/full-codegen.cc
M src/ia32/codegen-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/virtual-frame-ia32.cc
M src/liveedit.cc
M src/rewriter.cc
M src/scopeinfo.cc
M src/scopes.h
M src/scopes.cc
M src/variables.h
M src/variables.cc
M src/x64/codegen-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/virtual-frame-x64.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
