Kevin, could you comment on the my frame related reasonings below.
Vitaly,
Most LGTM, but I think we need some general approach to when to use
NearLabels
and when not to. I generally did not use NearLabels when it was not
immediately
clear from the immediate surroundings if there could potentially be more to
much
code by method calls.
In addition, I am not sure if we should use NearLabels if there is frame
related
calls involved - I will leave it to Kevin to comment on this (I might very
well
be wrong).
http://codereview.chromium.org/3386025/diff/1/2
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/3386025/diff/1/2#newcode2804
src/ia32/code-stubs-ia32.cc:2804: NearLabel unordered;
I probably would not use a NearLabel here since there is a number of
code generating method calls in the non sse2 case.
http://codereview.chromium.org/3386025/diff/1/2#newcode2989
src/ia32/code-stubs-ia32.cc:2989: __ mov(eax, Operand(esp, (argc_ + 1) *
kPointerSize));
receiver_is_value should be fine, as before I would use a nearlabel for
receiver_is_js_object
http://codereview.chromium.org/3386025/diff/1/4
File src/x64/code-stubs-x64.cc (right):
http://codereview.chromium.org/3386025/diff/1/4#newcode3100
src/x64/code-stubs-x64.cc:3100: NearLabel got_char_code;
again, some of these could be pretty long jumps
http://codereview.chromium.org/3386025/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
