Thanks for the comments. Please review for naming clarity.
http://codereview.chromium.org/3472006/diff/9001/8008 File src/objects.cc (right): http://codereview.chromium.org/3472006/diff/9001/8008#newcode2177 src/objects.cc:2177: // cleared if the object goes back to fast properties. On 2010/09/23 17:17:52, Vyacheslav Egorov wrote:
This comment is slightly confusing. The flag itself is cleared [not
set] on the
copy of the map and the map pointer of the object is replaced.
The comment should probably just state that fast maps cannot be marked
as
shared.
Done. http://codereview.chromium.org/3472006/diff/9001/8008#newcode8781 src/objects.cc:8781: obj->map()->set_is_shared(false); On 2010/09/23 17:17:52, Vyacheslav Egorov wrote:
This seems to be a weird place for this.
Should not we clean this bit in the very place where map is copied? [CopyDropDescriptors]
Done. http://codereview.chromium.org/3472006/diff/9001/8009 File src/objects.h (right): http://codereview.chromium.org/3472006/diff/9001/8009#newcode3204 src/objects.h:3204: bool shared); On 2010/09/23 17:17:52, Vyacheslav Egorov wrote:
Consider using enum instead of boolean to improve callsites
readability. Done. http://codereview.chromium.org/3472006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
