LGTM

http://codereview.chromium.org/3461021/diff/2001/3001
File src/globals.h (right):

http://codereview.chromium.org/3461021/diff/2001/3001#newcode218
src/globals.h:218: // Code entry points are aligned to 32 bytes (cache
line size in some CPUs).
In most of the CPUs we deal with it's actually 64. Please change the
parenthetical remark to "to improve cache line utilization".

http://codereview.chromium.org/3461021/diff/2001/3005
File src/spaces.h (right):

http://codereview.chromium.org/3461021/diff/2001/3005#newcode247
src/spaces.h:247: // code alignment to be suitabel for both.
Typo: "suitable".

http://codereview.chromium.org/3461021/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to