Unfortunately this change does not play well in the following case: return shared->is_compiled() || CompileLazyShared(shared, flag);
GCProtector created for shared->is_compiled() call will only be destroyed after the whole expression were evaluated. This leads to some bogus assertion failures. I decided to abandon this CL for now. -- Vyacheslav Egorov On Thu, Sep 23, 2010 at 12:19 PM, Vyacheslav Egorov <[email protected]> wrote: > Yep. Thanks. it might make sense to just use AssertNoAllocation. > -- > Vyacheslav Egorov > > > > On Thu, Sep 23, 2010 at 11:42 AM, Anton Muhin <[email protected]> wrote: >> Just in case duplicating the text: >> >> Drive by question/suggestion, feel free to ignore >> >> http://codereview.chromium.org/3452022/diff/1/4 >> File src/heap.h (right): >> >> http://codereview.chromium.org/3452022/diff/1/4#newcode1439 >> src/heap.h:1439: class GCUnsafeScope { >> should we unify it with AssertNoAllocation scope? >> >> On Thu, Sep 23, 2010 at 1:41 PM, <[email protected]> wrote: >>> <django.template.defaulttags.AutoEscapeControlNode object at >>> 0xc04c3ed029f00060> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
