http://codereview.chromium.org/3412034/diff/1/2 File src/parser.cc (right):
http://codereview.chromium.org/3412034/diff/1/2#newcode996 src/parser.cc:996: virtual void ResumeRecording() { On 2010/09/28 06:28:59, Søren Gjesse wrote:
ASSERT(pause_count > 0?
Done. http://codereview.chromium.org/3412034/diff/1/2#newcode1376 src/parser.cc:1376: parent->type_ = type; // TODO(lrn): Remove if not needed. Removed, it was just a mental note to check whether it's really needed. http://codereview.chromium.org/3412034/diff/1/2#newcode1377 src/parser.cc:1377: // Initialize functiois n hijacked by DummyScope to increment scope depth. Drag'n'drop error? Should be "function is". http://codereview.chromium.org/3412034/diff/1/4 File src/scopes.cc (right): http://codereview.chromium.org/3412034/diff/1/4#newcode204 src/scopes.cc:204: void Scope::Leave() { On 2010/09/28 06:28:59, Søren Gjesse wrote:
This could be in the .h file.
Done. http://codereview.chromium.org/3412034/diff/1/5 File src/scopes.h (right): http://codereview.chromium.org/3412034/diff/1/5#newcode388 src/scopes.h:388: inside_with_level_(-1) { On 2010/09/28 06:28:59, Søren Gjesse wrote:
Shouldn't there be a constant for this value?
Done. http://codereview.chromium.org/3412034/diff/1/5#newcode395 src/scopes.h:395: if (inside_with && inside_with_level_ < 0) { On 2010/09/28 06:28:59, Søren Gjesse wrote:
Compare with constant instead of < 0?
Done. http://codereview.chromium.org/3412034/diff/1/5#newcode423 src/scopes.h:423: // Highest scope nesting level that is contained in a with statement, or -1 On 2010/09/28 06:28:59, Søren Gjesse wrote:
Highest -> Lowest/First?
Done. http://codereview.chromium.org/3412034/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
