LGTM
http://codereview.chromium.org/3573005/diff/1/11 File src/heap.cc (right): http://codereview.chromium.org/3573005/diff/1/11#newcode706 src/heap.cc:706: int start_new_space_size = static_cast<int>(Heap::new_space()->IntSize()); seems wrong. http://codereview.chromium.org/3573005/diff/1/11#newcode4095 src/heap.cc:4095: *stats->new_space_size = new_space_.IntSize(); Better call this method SizeAsInt http://codereview.chromium.org/3573005/diff/1/18 File src/regexp-macro-assembler-tracer.cc (right): http://codereview.chromium.org/3573005/diff/1/18#newcode58 src/regexp-macro-assembler-tracer.cc:58: PrintF("label[%08x]: (Bind)\n", IntForLabel(label)); consider renaming it to LabelToInt. http://codereview.chromium.org/3573005/diff/1/21 File src/spaces.h (right): http://codereview.chromium.org/3573005/diff/1/21#newcode1482 src/spaces.h:1482: int IntSize() { return static_cast<int>(Size()); } SizeAsInt ? http://codereview.chromium.org/3573005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
