Reviewers: Vitaly,
Message:
Vitaly,
may you have a look?
Description:
Add another check to be sure non-negative smi fits into Uint32 range.
Please review this at http://codereview.chromium.org/3546003/show
Affected files:
M src/x64/ic-x64.cc
Index: src/x64/ic-x64.cc
diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc
index
47d4c938739705bebe1f5229deb0efa046f57086..814da760c88abab20e1226a08efbae6592c08448
100644
--- a/src/x64/ic-x64.cc
+++ b/src/x64/ic-x64.cc
@@ -894,6 +894,7 @@ void
KeyedLoadIC::GenerateIndexedInterceptor(MacroAssembler* masm) {
__ JumpIfSmi(rdx, &slow);
// Check that the key is an array index, that is Uint32.
+ STATIC_ASSERT(kSmiValueSize <= 32);
__ JumpIfNotPositiveSmi(rax, &slow);
// Get the map of the receiver.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
