Also (still LGTM):
http://codereview.chromium.org/3545004/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/3545004/diff/1/2#newcode474 include/v8.h:474: inline void Initialize(internal::Isolate* i) { Tiny nit, to consider, but I'm 50-50 on it myself: It feels that Initialize is used more like "Reset" (at least in api.cc). If the Data had a constructor taking Isolate*, then we could remove call to Initialize from isolate.cc and don't do change in api.cc. http://codereview.chromium.org/3545004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
